Allow Terms aggregations to define exact excludes and includes #1766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thePanz
force-pushed
the
fix-terms-aggratations-include
branch
from
8ab6508 to
1c6ae73
Compare
… include-partitions too)
thePanz
force-pushed
the
fix-terms-aggratations-include
branch
from
1c6ae73 to
2ec6466
Compare
ruflin
approved these changes
Mar 12, 2020
|
The only part I'm worried is that we need to add more functions if ES decides to add something new here. But at the same time, this is kind of how Elastica works ... |
|
@ruflin the functions here are helping to not memorize the ES endpoints. if something new comes up: , we can add a new method, but in the meanwhile the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow Terms aggregations to define:
Removed the
$flagsfrom thesetInclude()as not supported by ES anymoreCloses #1764