Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure library folders #1755

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Restructure library folders #1755

merged 1 commit into from
Feb 13, 2020

Conversation

thePanz
Copy link
Collaborator

@thePanz thePanz commented Feb 11, 2020

Checklist:

  • Move lib/Elastica/ under src/
  • Move test/Elastica/ under tests/
  • Adjust composer.json accordingly

ruflin
ruflin reviewed Feb 11, 2020
View reviewed changes
test/phpunit.xhprof.xml Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@thePanz thePanz changed the title Restructure library folder structures Restructure library folders Feb 11, 2020
ruflin
ruflin approved these changes Feb 11, 2020
View reviewed changes
Copy link
Owner

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Changelog can be fixed in this PR or a follow up ;-)

CHANGELOG.md Show resolved Hide resolved
@thePanz
Copy link
Collaborator Author

thePanz commented Feb 12, 2020

@ruflin I will rebase this and add the BC notice to the changelog :)

@ruflin ruflin merged commit 92a9a42 into ruflin:master Feb 13, 2020
@thePanz thePanz deleted the refactor-project-folders branch February 13, 2020 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thePanz @ruflin