Ensure the search::count() is counting all results #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thePanz
force-pushed
the
search-count-should-count-all-results
branch
from
59dc7e6
to
a792b3f
Compare
thePanz
force-pushed
the
search-count-should-count-all-results
branch
from
a792b3f
to
c2ba423
Compare
thePanz
force-pushed
the
search-count-should-count-all-results
branch
from
c2ba423
to
bb52f3f
Compare
ruflin
approved these changes
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Search::count() implementation is not taking into consideration the track-total-hits setting in ES, fhus only returning the count for the first 10000 results.
This PR makes sure that the track-total-hits is set to
true, allowing all results to be counted.