Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not throw NotFoundException when deleting documents by ID #1732

Merged
merged 1 commit into from
Dec 12, 2019
Merged

Do not throw NotFoundException when deleting documents by ID #1732

merged 1 commit into from
Dec 12, 2019

Conversation

thePanz
Copy link
Collaborator

@thePanz thePanz commented Dec 11, 2019

Rewrite of #1317

@thePanz thePanz force-pushed the do-not-throw-exceptions-on-doc-deletion branch from 53b3bba to 863e521 Compare December 11, 2019 15:13
@thePanz thePanz requested a review from ruflin December 11, 2019 17:20
@ruflin ruflin merged commit f0d5872 into ruflin:master Dec 12, 2019
@ruflin
Copy link
Owner

ruflin commented Dec 12, 2019

@thePanz I assume #1317 can now be closed?

@thePanz thePanz deleted the do-not-throw-exceptions-on-doc-deletion branch December 12, 2019 10:16
@thePanz thePanz mentioned this pull request Dec 12, 2019
Closed
@thePanz
Copy link
Collaborator Author

thePanz commented Dec 12, 2019

Yup, I closed it! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deguif deguif deguif approved these changes

@ruflin ruflin Awaiting requested review from ruflin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thePanz @ruflin @deguif