Added Collapse DSL to QueryBuilder #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deguif
approved these changes
Dec 4, 2019
CHANGELOG.md
Outdated
| @@ -25,6 +25,7 @@ All notable changes to this project will be documented in this file based on the | |||
| * Launch tests with PHP 7.4 | |||
| * Added `nullable_type_declaration_for_default_null_value`, `no_alias_functions` CS rules [#1706](https://github.com/ruflin/Elastica/pull/1706) | |||
| * Configured `visibility_required` CS rule for constants [#1723](https://github.com/ruflin/Elastica/pull/1723) | |||
| * Added `Collapse` DSL to `QueryBuilder` | |||
There was a problem hiding this comment.
Just a minor comment, but it would be perfect if you add the link to the PR ;)
deguif
reviewed
Dec 4, 2019
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| namespace Elastica\QueryBuilder\DSL; | |||
|
|
|||
| use Elastica\Query\InnerHits; | |||
| use Elastica\Collapse\InnerHits; | |||
|
@wackerl91 Thanks for the contribution and cleanup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's going to be a bit awkward now: in the PR that added Field Collapsing Support (#1653) I forgot to check in the DSL classes, which made working with it a bit clumsy compared to the usual query methods.
I.e. - as with aggregations - it's now possible to do stuff like this:
Let me know if there need to be any changes. Cheers :)