Test on PHP 7.4 #1704
Merged
Test on PHP 7.4 #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@deguif Could you take a look at the test failure? It might tell us actually about a potential bug? |
deguif
force-pushed
the
support-php-74
branch
from
ed4e7c3 to
21785a7
Compare
deguif
commented
Nov 18, 2019
| @@ -745,7 +745,7 @@ public function testUpdateWithInvalidType() | |||
| try { | |||
| $client->updateDocument(1, $badDocument, $index->getName()); | |||
| $this->fail('Tried to update using an object that is not a Document or a Script but no exception was thrown'); | |||
| } catch (\Exception $e) { | |||
| } catch (\Throwable $e) { | |||
There was a problem hiding this comment.
@ruflin That should fix the test. As a PHP error was thrown ;)
|
Great to have it now also tested on 7.4 |
|
Yes, and we will have to update the docker tag, once GA release is out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.