Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update query builder query dsl #1702

Merged
merged 2 commits into from
Nov 19, 2019

Conversation

deguif
Copy link
Collaborator

@deguif deguif commented Nov 18, 2019

No description provided.

@deguif deguif force-pushed the upgrade-query-builder-queries branch from 6039365 to 0c05a0c Compare November 18, 2019 15:51
@deguif
Copy link
Collaborator Author

deguif commented Nov 18, 2019

I just added the CHANGELOG entry.

@deguif
Copy link
Collaborator Author

deguif commented Nov 19, 2019

@ruflin do you think this can be merged?
I'm relying on the query builder a lot in my code base, so I would really love to get this merged.

@ruflin ruflin merged commit 7e846bc into ruflin:master Nov 19, 2019
@ruflin
Copy link
Owner

ruflin commented Nov 19, 2019

@deguif yes

Interesting to hear that you are heavily relying on the query builder. It is one of these features I thought we should potentially remove but sounds like there are users out there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants