Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Query documentation #1679

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Cleanup Query documentation #1679

merged 1 commit into from
Oct 22, 2019

Conversation

thePanz
Copy link
Collaborator

@thePanz thePanz commented Oct 18, 2019 •
edited
Loading

Cleanup Query documentation for ES-7

  • add ): self to fluent methods
  • remove un-needed @return $this annotations
  • Updated changelog for breaking changes

@thePanz thePanz force-pushed the improve-query-documentation-es-7 branch from 3d61716 to 838a148 Compare October 18, 2019 10:07
ruflin
ruflin reviewed Oct 21, 2019
View reviewed changes
@ruflin
Copy link
Owner

ruflin commented Oct 21, 2019

Seems CI is not happy :-(

@thePanz thePanz force-pushed the improve-query-documentation-es-7 branch from 838a148 to 3645bdd Compare October 22, 2019 09:31
@ruflin ruflin merged commit aee63ec into ruflin:master Oct 22, 2019
@ruflin
Copy link
Owner

ruflin commented Oct 22, 2019

Thanks!

@thePanz thePanz deleted the improve-query-documentation-es-7 branch December 20, 2019 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thePanz @ruflin