Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not call toArray method in Query::toArray #1471

Closed
wants to merge 2 commits into from
Closed

Do not call toArray method in Query::toArray #1471

wants to merge 2 commits into from

Conversation

XWB
Copy link
Contributor

@XWB XWB commented Mar 1, 2018 •
edited
Loading

Fixes #1429, introduced in #1378

Unless I'm missing something, we should not call toArray in Query::toArray. Either post_filter is already an array, or it is an instance of AbstractQuery which implements Countable through Param anyway.

@ruflin
Copy link
Owner

ruflin commented Mar 4, 2018

@XWB Any chance you could add a test for this to make sure we do not reintroduce this?

@deguif deguif mentioned this pull request Mar 24, 2021
Merged
@deguif
Copy link
Collaborator

deguif commented Mar 24, 2021

Closing as it should be fixed by #1950
Second fix is also fixed in master since #1696 was merged

@deguif deguif closed this Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Call to a member function toArray() on array
3 participants
@XWB @ruflin @deguif