ES6 use strict type on boolean (true|false) #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
approved these changes
Aug 14, 2017
| ### Backward Compatibility Breaks | ||
| - Numeric to and from parameters in [date_range aggregation](https://www.elastic.co/guide/en/elasticsearch/reference/6.0/breaking_60_aggregations_changes.html#_numeric_literal_to_literal_and_literal_from_literal_parameters_in_literal_date_range_literal_aggregation_are_interpreted_according_to_literal_format_literal_now) are interpreted according to format of the target field | ||
|
|
||
| - Numeric to and from parameters in [date_range aggregation](https://www.elastic.co/guide/en/elasticsearch/reference/6.0/breaking_60_aggregations_changes.html#_numeric_literal_to_literal_and_literal_from_literal_parameters_in_literal_date_range_literal_aggregation_are_interpreted_according_to_literal_format_literal_now) are interpreted according to format of the target field |
There was a problem hiding this comment.
We should also link to the PR number. I'm aware this is normally tricky before opening the PR because it is not known yet :-)
There was a problem hiding this comment.
ok I'll update it in the next PR
| @@ -16,15 +16,15 @@ class BoostingTest extends BaseTest | |||
| ['name' => 'Vital Match', 'price' => 2.1], | |||
| ['name' => 'Mercury Vital', 'price' => 7.5], | |||
| ['name' => 'Fist Mercury', 'price' => 3.8], | |||
| ['name' => 'Lama Vital 2nd', 'price' => 3.2], | |||
| ['name' => 'Lama Vital 2nd', 'price' => 1.2], | |||
There was a problem hiding this comment.
I was testing also the BoostingTest.php, and I forget to remove it during the creation of the PR. in the next PR I will update it.
| @@ -28,8 +26,8 @@ public function testSearch() | |||
|
|
|||
| $type = new Type($index, 'helloworldmlt'); | |||
| $mapping = new Mapping($type, [ | |||
| 'email' => ['store' => 'true', 'type' => 'text', 'index' => 'analyzed'], | |||
| 'content' => ['store' => 'true', 'type' => 'text', 'index' => 'analyzed'], | |||
| 'email' => ['store' => 'true', 'type' => 'text', 'index' => 'true'], | |||
There was a problem hiding this comment.
We could probably now use true instead of 'true' here?
There was a problem hiding this comment.
dunno why :) revert in next PR, sorry.
|
Decided to already merge this as all of the comments we can fix in follow up comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated failing tests failing on boolean type or on legacy values
Removed the use of values different from TRUE or FALSE as strict boolean type implemented in ES6.
Removed 'analyzed' and not analyzed as index mapping now accepts only TRUE|FALSE
Updated the use of store mapping with BOOLEAN