Fix direct generators deprecation errors #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicklaw5
added a commit
to ramuss/FazlandElasticaBundle
that referenced
this pull request
Apr 5, 2017
A PR has been submitted here: ruflin/Elastica#1282
|
Thanks for the change. LGTM. Could you update the CHANGELOG.md? |
Deprecation of the below is now enforced in 5.3 - "prefix_len" becomes "prefix_length" - "min_word_len" becomes "min_word_length"
nicklaw5
force-pushed
the
fix-deprecation-errors-in-5.3
branch
from
aa95f7a
to
0fc537a
Compare
|
@ruflin changelog has been updated. |
|
@nicklaw5 Thanks, merged. |
mhernik
pushed a commit
to mhernik/Elastica
that referenced
this pull request
Jul 24, 2017
Deprecation of the below is now enforced in 5.3 - "prefix_len" becomes "prefix_length" - "min_word_len" becomes "min_word_length"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecation of the below is now enforced in 5.3
Docs: https://www.elastic.co/guide/en/elasticsearch/reference/current/search-suggesters-phrase.html#_direct_generators