Make a test in ClientTest more consistent #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClientTest->testDeleteIdsIdxStringTypeString assumed that new documents created without a specified id or routing value would route to the same shard as "1" and a different shard from "2" when there are two shards. This wasn't always that case because: 1. Documents without a routing value use their ids as a route. 2. Documents that don't specify an id get a random one. This sets the routing for the document to "1" which, luckily, does in fact route to a different shard then "2" when there are two shards. And it will stay that way forever back Elasticsearch has to maintain a consistent routing style or it won't be safe to upgrade. Closes ruflin#633
|
I'm actually not sure how it worked before this. I didn't go digging into history, only Elasticsearch's source code. |
|
Looks promising. Now we need to figure out the random testOverride failure :-( |
|
I'll have a look. |
ruflin
added a commit
that referenced
this pull request
Jun 13, 2014
Make a test in ClientTest more consistent
|
Merged this one so we can check this in a new pull request. I think this problem is solved. Thx a lot. |
|
Unfortunate: I just amended and pushed a fix for the other test. |
|
Let me disentangle. |
|
Sorry :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClientTest->testDeleteIdsIdxStringTypeString assumed that new documents
created without a specified id or routing value would route to the same
shard as "1" and a different shard from "2" when there are two shards.
This wasn't always that case because:
This sets the routing for the document to "1" which, luckily, does in
fact route to a different shard then "2" when there are two shards. And
it will stay that way forever back Elasticsearch has to maintain a consistent
routing style or it won't be safe to upgrade.
Closes #633