Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientTest->testDeleteIdsIdxStringTypeString fails about 1/3 of the time #633

Closed
nik9000 opened this issue Jun 13, 2014 · 0 comments · Fixed by #634
Closed

ClientTest->testDeleteIdsIdxStringTypeString fails about 1/3 of the time #633

nik9000 opened this issue Jun 13, 2014 · 0 comments · Fixed by #634

Comments

@nik9000
Copy link
Contributor

nik9000 commented Jun 13, 2014

No description provided.

nik9000 pushed a commit to nik9000/Elastica that referenced this issue Jun 13, 2014
ClientTest->testDeleteIdsIdxStringTypeString assumed that new documents
created without a specified id or routing value would route to the same
shard as "1" and a different shard from "2" when there are two shards.
This wasn't always that case because:
1.  Documents without a routing value use their ids as a route.
2.  Documents that don't specify an id get a random one.

This sets the routing for the document to "1" which, luckily, does in
fact route to a different shard then "2" when there are two shards.  And
it will stay that way forever back Elasticsearch has to maintain a consistent
routing style or it won't be safe to upgrade.

Closes ruflin#633
nik9000 pushed a commit to nik9000/Elastica that referenced this issue Jun 13, 2014
ClientTest->testDeleteIdsIdxStringTypeString assumed that new documents
created without a specified id or routing value would route to the same
shard as "1" and a different shard from "2" when there are two shards.
This wasn't always that case because:
1.  Documents without a routing value use their ids as a route.
2.  Documents that don't specify an id get a random one.

This sets the routing for the document to "1" which, luckily, does in
fact route to a different shard then "2" when there are two shards.  And
it will stay that way forever back Elasticsearch has to maintain a consistent
routing style or it won't be safe to upgrade.

Closes ruflin#633
nik9000 pushed a commit to nik9000/Elastica that referenced this issue Jun 13, 2014
ClientTest->testDeleteIdsIdxStringTypeString assumed that new documents
created without a specified id or routing value would route to the same
shard as "1" and a different shard from "2" when there are two shards.
This wasn't always that case because:
1.  Documents without a routing value use their ids as a route.
2.  Documents that don't specify an id get a random one.

This sets the routing for the document to "1" which, luckily, does in
fact route to a different shard then "2" when there are two shards.  And
it will stay that way forever back Elasticsearch has to maintain a consistent
routing style or it won't be safe to upgrade.

Closes ruflin#633
nik9000 pushed a commit to nik9000/Elastica that referenced this issue Jun 13, 2014
ClientTest->testDeleteIdsIdxStringTypeString assumed that new documents
created without a specified id or routing value would route to the same
shard as "1" and a different shard from "2" when there are two shards.
This wasn't always that case because:
1.  Documents without a routing value use their ids as a route.
2.  Documents that don't specify an id get a random one.

This sets the routing for the document to "1" which, luckily, does in
fact route to a different shard then "2" when there are two shards.  And
it will stay that way forever back Elasticsearch has to maintain a consistent
routing style or it won't be safe to upgrade.

ScanAndScrollTest->testQuerySizeOverride used the ->rewind method on
ScanAndScroll which executes a scroll query on Elasticsearch without making
sure that the index is fully allocated.  Apparently, this can cause
Elasticsearch to throw back an error.  We work around this by adding a
refresh before the rewind.

Closes ruflin#633
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant