-
-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve TextField.autoSize, implement TextField.background #3163
Conversation
9b18211
to
5cc767e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good. Everything is clean and functional.
Same here. I'll point out that you should also make sure the other |
As the author of #3156 this looks promising, though obviously it would be better for me if it fully fixed that issue. Semi-related; this may not be the best place for this comment, but I thought I'd mention this since my issue was mentioned: I added more SWFs with the same problem to the issue. They are nearly identical files, but maybe they will give a clue as to the behavior that you "don't fully understand". I thought they were redundant, but better to include too much detail than too little. Edit: Further testing revealed a slight difference in the problems with some of the SWFs versus others. See latest comment on the issue for further details since this is not the place for me to mention them. |
I hoped the existing tests would "handle themselves" without having me actually look at them (especially if they pass) :) |
@craniumcadoo FYI:
From what I see, my patch seems to fix this particular behavior. |
Also none of the existing EditText tests are affected, from visual inspection. |
5cc767e
to
d4b8873
Compare
d4b8873
to
bcfc96e
Compare
First commit makes TextField better respect properties of autoSize: with "left", it extends to the right from
_x
; with "right", it extends to the left from_x+_width
. This doesn't affect text layout; just where the text field appears in the end.This is not a full fix of any issue; in fact, this doesn't fix completely any issues, just improve them a bit. In particular, various missing parts I noticed:
console.log(el.offsetLeft)
triggers reflow in JS), not on each property settextFormat.align
and align text to right;As for improvements:
autoSize
is enabledTextField.background
flag - before, we would draw background wheneverborder=true
, which wasn't correct.Screenshots:
Nanaca Crash: Misaligned 'record' numbers #1440: