-
-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video base/stub impls #3117
Video base/stub impls #3117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, passes all checks, and nothing looks wrong, although it needs further review, as I am not as experienced in Rust as I am in other languages.
72d983e
to
c03521f
Compare
This is far more awkward and copy-heavy than it needs to be.
…store software decoders.
`PlaceObject`'s `ratio` field is treated as a seek parameter for video streams.
c03521f
to
afc5553
Compare
First, I want to say that I do not know any Rust. Second, I want to say thank you for working on this. I am especially excited for the VP6 branch built off of this one, because that will make many of the videos on the sites I work on work (I tested it on one of them and the results look promising). I found an issue with this branch versus the official Ruffle release (using a Chrome extension built from this branch versus an official Chrome release). If you go to http://www.insidecancer.org/ with this version of Ruffle, clicking any button on the animation doesn't load anything at all inside the "frame". The animation works accurately with the official Ruffle release, except of course for the videos, which do not work (easiest video to get to would be clicking "Hallmarks of Cancer", and then number "7"), as well as the scroll bar on certain slides (easiest non-working scroll bar to get to would be "Causes and Prevention", "3", "→", which I suspect would work if TextField.scroll were implemented - #280). |
Thank you! |
As requested I have extracted all of the non-codec Video support - a fresh display object, associated AVM stubs, and so on. This PR will recognize video tracks in an SWF, store them, and then generate errors as it has no codecs to work with. I've also reorganized the H.263 PR to be downstream of this one. Merging that PR will also merge this one.
I expect the person working on libav VP6 integration (szooloo on Discord but I don't know their Github username) to also make use of this base PR.
As this contains no codecs there should be no patent exposure from merging it.