Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "ci: Temporarily pin to Node 22.4" #17181

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Revert "ci: Temporarily pin to Node 22.4" #17181

merged 1 commit into from
Jul 22, 2024

Conversation

danielhjacobs
Copy link
Contributor

Reverts #17169

@danielhjacobs danielhjacobs marked this pull request as draft July 19, 2024 14:48
@danielhjacobs
Copy link
Contributor Author

Waiting on Node 22.5.1 to be added to https://github.com/actions/node-versions/releases/

@torokati44
Copy link
Member

It's on there now.

@danielhjacobs
Copy link
Contributor Author

Still falling, we may need the manifest update: actions/node-versions#182

@torokati44
Copy link
Member

Yeah, that's possible.

@torokati44 torokati44 mentioned this pull request Jul 19, 2024
Merged
@torokati44 torokati44 force-pushed the revert-17169-danielhjacobs-patch-1 branch from ab0d2ed to 4f3b90e Compare July 22, 2024 10:18
@torokati44
Copy link
Member

This is finally unblocked.

@danielhjacobs danielhjacobs marked this pull request as ready for review July 22, 2024 11:46
@danielhjacobs danielhjacobs merged commit a7674a5 into master Jul 22, 2024
17 checks passed
@danielhjacobs danielhjacobs deleted the revert-17169-danielhjacobs-patch-1 branch July 22, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torokati44 torokati44 torokati44 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielhjacobs @torokati44