Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: iterable EUDC deleteUsers #3881

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

aanshi07
Copy link
Contributor

@aanshi07 aanshi07 commented Nov 15, 2024

What are the changes introduced in this PR?

Added EUDC delete users API support

What is the related Linear task?

Resolves INT-2606

DOC: https://support.iterable.com/hc/en-us/articles/360032290032-Deleting-Users

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@aanshi07 aanshi07 self-assigned this Nov 15, 2024
@aanshi07 aanshi07 requested review from a team and sivashanmukh as code owners November 15, 2024 13:21
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.44%. Comparing base (e90d2ad) to head (48b1043).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3881      +/-   ##
===========================================
+ Coverage    89.05%   90.44%   +1.38%     
===========================================
  Files          618      610       -8     
  Lines        33071    32135     -936     
  Branches      7814     7646     -168     
===========================================
- Hits         29452    29065     -387     
+ Misses        3336     2815     -521     
+ Partials       283      255      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aanshi07 aanshi07 merged commit becb4fa into develop Nov 15, 2024
27 of 33 checks passed
@aanshi07 aanshi07 deleted the feat.iterable_EUDC_deleteUsers branch November 15, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants