chore: base support for raising stat per tracking plan event #2847

abhimanyubabbar · 2023-11-22T13:21:36Z

Description of the change

In this change, we have refactored the code to allow for capturing stats per tracking plan event validation. This will allow us to write better fine grained alerts over the tracking plan changes.

DAT-340
https://linear.app/rudderstack/issue/DAT-340/trackingplan-stats-capture-include-state-statuscode-per-event-level

Type of change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

Lint rules pass locally
The code changed/added as part of this pull request has been covered with tests
All tests related to the changed code pass in development

Code review

This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
"Ready for review" label attached to the PR and reviewers mentioned in a comment
Changes have been reviewed by at least one other engineer
Issue from task tracker has a link to this pull request

sonarqubecloud · 2023-11-22T13:27:23Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

codecov · 2023-11-22T13:27:46Z

Codecov Report

Attention: Patch coverage is 12.00000% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 84.83%. Comparing base (c1b3736) to head (dbd574d).
Report is 16 commits behind head on develop.

Files	Patch %	Lines
src/services/trackingPlan.ts	8.69%	21 Missing ⚠️
src/controllers/trackingPlan.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2847      +/-   ##
===========================================
- Coverage    84.86%   84.83%   -0.03%     
===========================================
  Files          497      498       +1     
  Lines        27412    27442      +30     
  Branches      6597     6603       +6     
===========================================
+ Hits         23262    23281      +19     
- Misses        3723     3731       +8     
- Partials       427      430       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/controllers/trackingPlan.ts

devops-github-rudderstack · 2023-12-18T01:26:34Z

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

coderabbitai · 2024-02-05T17:35:12Z

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

devops-github-rudderstack · 2024-02-05T17:37:33Z

Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/2847/test-report.html

devops-github-rudderstack · 2024-02-05T17:37:37Z

Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/2847/test-report.html

devops-github-rudderstack · 2024-02-05T17:38:11Z

Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/2847/test-report.html

devops-github-rudderstack · 2024-02-06T10:44:43Z

Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/2847/test-report.html

sonarqubecloud · 2024-02-06T10:47:07Z

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

devops-github-rudderstack · 2024-02-27T01:21:54Z

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

src/services/trackingPlan.ts

kanishkkatara · 2024-03-12T10:53:42Z

src/services/trackingPlan.ts

-    for (let i = 0; i < events.length; i++) {
-      const event = events[i];
-      const eventStartTime = new Date();
+    for (let event of events) {


Isn't this line causing an ESLint error, suggesting the use of iterators instead of loops?

eslint has been blocked for the trackingPlan files. I'll change it nonetheless, point has been raised before as well.

kanishkkatara · 2024-03-12T10:54:30Z

src/services/trackingPlan.ts

+    for (let event of events) {
+      let eventValidationResponse: any;
+      let exceptionOccured = false;
+      let eventStartTime = Date.now();


Suggested change

let eventStartTime = Date.now();

const eventStartTime = Date.now();

sonarqubecloud · 2024-03-12T15:07:49Z

Quality Gate failed

Failed conditions
80.6% Duplication on New Code (required ≤ 15%)

See analysis details on SonarCloud

abhimanyubabbar requested review from sivashanmukh and a team as code owners November 22, 2023 13:21

abhimanyubabbar changed the title ~~chore: added base support for raising event per tracking plan event~~ chore: base support for raising event per tracking plan event Nov 22, 2023

abhimanyubabbar changed the title ~~chore: base support for raising event per tracking plan event~~ chore: base support for raising stat per tracking plan event Nov 22, 2023

Jayachand reviewed Nov 27, 2023

View reviewed changes

src/controllers/trackingPlan.ts Outdated Show resolved Hide resolved

devops-github-rudderstack added the Stale label Dec 18, 2023

devops-github-rudderstack closed this Dec 26, 2023

abhimanyubabbar reopened this Feb 5, 2024

abhimanyubabbar force-pushed the chore.raise-stats-per-tracking-plan-event branch from 7db76a1 to 99d0368 Compare February 5, 2024 17:35

devops-github-rudderstack removed the Stale label Feb 6, 2024

abhimanyubabbar force-pushed the chore.raise-stats-per-tracking-plan-event branch from 99d0368 to 9931404 Compare February 6, 2024 10:41

devops-github-rudderstack added the Stale label Feb 27, 2024

Jayachand removed the Stale label Feb 28, 2024

Jayachand reviewed Mar 11, 2024

View reviewed changes

src/services/trackingPlan.ts Show resolved Hide resolved

Jayachand reviewed Mar 11, 2024

View reviewed changes

src/services/trackingPlan.ts Outdated Show resolved Hide resolved

abhimanyubabbar requested review from a team as code owners March 11, 2024 17:30

abhimanyubabbar requested review from chandumlg and sandeepdsvs March 11, 2024 17:30

abhimanyubabbar force-pushed the chore.raise-stats-per-tracking-plan-event branch from 357291a to 0e9ada9 Compare March 11, 2024 18:06

Jayachand reviewed Mar 11, 2024

View reviewed changes

src/services/trackingPlan.ts Show resolved Hide resolved

Jayachand reviewed Mar 11, 2024

View reviewed changes

src/services/trackingPlan.ts Outdated Show resolved Hide resolved

Jayachand reviewed Mar 12, 2024

View reviewed changes

src/services/trackingPlan.ts Outdated Show resolved Hide resolved

abhimanyubabbar commented Mar 12, 2024

View reviewed changes

src/services/trackingPlan.ts Show resolved Hide resolved

Jayachand previously approved these changes Mar 12, 2024

View reviewed changes

abhimanyubabbar dismissed Jayachand’s stale review via 54a4ffb March 12, 2024 10:47

abhimanyubabbar force-pushed the chore.raise-stats-per-tracking-plan-event branch from 54a4ffb to 11ccb13 Compare March 12, 2024 10:50

kanishkkatara reviewed Mar 12, 2024

View reviewed changes

Jayachand previously approved these changes Mar 12, 2024

View reviewed changes

chore: added base support for raising event per tracking plan event

dbd574d

abhimanyubabbar dismissed Jayachand’s stale review via dbd574d March 12, 2024 15:01

abhimanyubabbar force-pushed the chore.raise-stats-per-tracking-plan-event branch from 11ccb13 to dbd574d Compare March 12, 2024 15:01

kanishkkatara approved these changes Mar 12, 2024

View reviewed changes

Jayachand approved these changes Mar 13, 2024

View reviewed changes

Jayachand merged commit bdc0f41 into develop Mar 13, 2024
15 of 16 checks passed

Jayachand deleted the chore.raise-stats-per-tracking-plan-event branch March 13, 2024 09:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: base support for raising stat per tracking plan event #2847

chore: base support for raising stat per tracking plan event #2847

abhimanyubabbar commented Nov 22, 2023 •

edited

Loading

sonarqubecloud bot commented Nov 22, 2023

codecov bot commented Nov 22, 2023 •

edited

Loading

devops-github-rudderstack commented Dec 18, 2023

coderabbitai bot commented Feb 5, 2024 •

edited

Loading

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

devops-github-rudderstack commented Feb 5, 2024

devops-github-rudderstack commented Feb 5, 2024

devops-github-rudderstack commented Feb 5, 2024

devops-github-rudderstack commented Feb 6, 2024

sonarqubecloud bot commented Feb 6, 2024

devops-github-rudderstack commented Feb 27, 2024

kanishkkatara Mar 12, 2024

abhimanyubabbar Mar 12, 2024

kanishkkatara Mar 12, 2024

sonarqubecloud bot commented Mar 12, 2024

	let eventStartTime = Date.now();
	const eventStartTime = Date.now();

chore: base support for raising stat per tracking plan event #2847

chore: base support for raising stat per tracking plan event #2847

Conversation

abhimanyubabbar commented Nov 22, 2023 • edited Loading

Description of the change

Type of change

Related issues

Checklists

Development

Code review

sonarqubecloud bot commented Nov 22, 2023

codecov bot commented Nov 22, 2023 • edited Loading

Codecov Report

devops-github-rudderstack commented Dec 18, 2023

coderabbitai bot commented Feb 5, 2024 • edited Loading

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

devops-github-rudderstack commented Feb 5, 2024

devops-github-rudderstack commented Feb 5, 2024

devops-github-rudderstack commented Feb 5, 2024

devops-github-rudderstack commented Feb 6, 2024

sonarqubecloud bot commented Feb 6, 2024

Quality Gate passed

devops-github-rudderstack commented Feb 27, 2024

kanishkkatara Mar 12, 2024

Choose a reason for hiding this comment

abhimanyubabbar Mar 12, 2024

Choose a reason for hiding this comment

kanishkkatara Mar 12, 2024

Choose a reason for hiding this comment

sonarqubecloud bot commented Mar 12, 2024

Quality Gate failed

abhimanyubabbar commented Nov 22, 2023 •

edited

Loading

codecov bot commented Nov 22, 2023 •

edited

Loading

coderabbitai bot commented Feb 5, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)