Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: split unit tests #3416

Merged
merged 1 commit into from
May 29, 2023
Merged

chore: split unit tests #3416

merged 1 commit into from
May 29, 2023

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented May 29, 2023

Description

Split unit test to have separate for server and warehouse.

Notion Ticket

https://www.notion.so/rudderstacks/Split-unit-tests-17b9ccd7a2c440d5adfbffc2d758ae57?pvs=4

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@atzoum
Copy link
Contributor

atzoum commented May 29, 2023

Could we do the same for more packages (main modules)?

  • jobsdb
  • gateway
  • processor
  • router

@achettyiitr
Copy link
Member Author

Could we do the same for more packages (main modules)?

  • jobsdb
  • gateway
  • processor
  • router

Yeah.

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (1ccec6e) 68.58% compared to head (1860739) 68.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3416      +/-   ##
==========================================
- Coverage   68.58%   68.57%   -0.02%     
==========================================
  Files         329      330       +1     
  Lines       52778    52820      +42     
==========================================
+ Hits        36196    36219      +23     
- Misses      14252    14268      +16     
- Partials     2330     2333       +3     

see 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@achettyiitr achettyiitr merged commit 471a562 into master May 29, 2023
@achettyiitr achettyiitr deleted the chore.split-unit-test branch May 29, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants