Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(new integration): SnapEngage web Device mode integration onboarding #612

Merged
merged 7 commits into from
Aug 18, 2022
Merged

feature(new integration): SnapEngage web Device mode integration onboarding #612

merged 7 commits into from
Aug 18, 2022

Conversation

rohithkaza
Copy link
Contributor

@rohithkaza rohithkaza commented Aug 16, 2022 •
edited by SumanthPuram
Loading

Description of the change

Onboarding SnapEngage

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@rohithkaza rohithkaza requested a review from utsabc as a code owner August 16, 2022 05:00
@rohithkaza rohithkaza self-assigned this Aug 16, 2022
@rohithkaza rohithkaza requested a review from saikumarrs as a code owner August 16, 2022 05:00
@rohithkaza rohithkaza requested a review from ItsSudip August 16, 2022 05:00
ItsSudip
ItsSudip reviewed Aug 16, 2022
View reviewed changes
ItsSudip
ItsSudip requested changes Aug 17, 2022
View reviewed changes
ItsSudip
ItsSudip requested changes Aug 17, 2022
View reviewed changes
@ItsSudip ItsSudip merged commit b7062f2 into v1-staging Aug 18, 2022
@ItsSudip ItsSudip deleted the feature/snapengage branch August 18, 2022 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utsabc utsabc utsabc approved these changes

@ItsSudip ItsSudip ItsSudip approved these changes

@saikumarrs saikumarrs Awaiting requested review from saikumarrs

Assignees

@rohithkaza rohithkaza

Labels
new-integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rohithkaza @utsabc @ItsSudip