Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: clean the dependencies #577

Merged
merged 2 commits into from
Aug 10, 2022

Conversation

saikumarrs
Copy link
Member

@saikumarrs saikumarrs commented Jul 23, 2022

Description of the change

Use the correct format for the dependencies.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

N/A

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@github-actions
Copy link

github-actions bot commented Jul 23, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Core - CDN 36.92 KB (0%) 739 ms (0%) 788 ms (-0.66% 🔽) 1.6 s
All Integrations - CDN 666.73 KB (0%) 13.4 s (0%) 3.9 s (-1.57% 🔽) 17.3 s
Core - NPM 37.13 KB (0%) 743 ms (0%) 617 ms (+13.01% 🔺) 1.4 s

@saikumarrs saikumarrs changed the base branch from production to production-staging July 23, 2022 18:39
@saikumarrs saikumarrs marked this pull request as ready for review July 23, 2022 19:10
@saikumarrs saikumarrs requested a review from MoumitaM as a code owner July 23, 2022 19:10
@saikumarrs saikumarrs merged commit 626946c into production-staging Aug 10, 2022
@saikumarrs saikumarrs deleted the patch/dependencies-cleanup branch August 10, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants