Bug 485. URL encode DID names. #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maany
reviewed
Oct 18, 2024
|
Hey @MytsV, could you also update the gateway endpoint to url encode any query parameters going out of the webui to the rucio server. I believe if you change the SDK, we should be able to capture all such usecases in a single go. |
|
The test I fixed send a request with a slash but didn't account for encoding. In general, I'll try to perform some additional checks |
MytsV
force-pushed
the
bug-485-slash_dids_resolution
branch
from
0ddbaa9 to
c37eb41
Compare
maany
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #485
With this fix, the detailed view of the DIDs should become functional when slashes are present in the name.