Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 495. Update the experiment icon link on changing PROJECT_URL environmental variable. #496

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Bug 495. Update the experiment icon link on changing PROJECT_URL environmental variable. #496

merged 1 commit into from
Oct 18, 2024

Conversation

MytsV
Copy link
Contributor

@MytsV MytsV commented Oct 17, 2024

Fix #495

@MytsV MytsV requested a review from maany October 17, 2024 14:58
maany
maany approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@maany maany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p.s. we would have to introduce a new env var called PROJECT_ICON that would take the base64 encoded icons and render them here. I believe that would be a separate issue?

@maany maany added this to the 35.4.0 milestone Oct 18, 2024
@maany maany merged commit fbe2531 into rucio:master Oct 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maany maany maany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
35.4.0
Development

Successfully merging this pull request may close these issues.

PROJECT_URL does not update the link when clicking the experiment icon
2 participants
@MytsV @maany