-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 46 add org logos #49
Conversation
.env.template
Outdated
|
||
[login_page_org_images] | ||
REACT_APP_login_page_org_image_1 = ./images/favicon.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's say that the Rucio logo is always going to be present. In addition, Let's just use 2 images, REACT_APP_login_page_image_primary
and REACT_APP_login_page_image_secondary
.
We can render all images in the order ( L-R) in a single row : primary -> rucio_logo -> secondary
@bari12 @cserf @mlassnig any comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me, made the changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @nimishbongale , It's cool to support up to 5 images, but I believe we could keep it a bit simpler. ( Also presenting too many configuration options to the end-users might not play well for a user PoV)
Makes sense. We decided upon supporting 2/3 images, one secondary and one primary, which would both come on the same line, and for now I could add the ATLAS logo for the secondary logo image. |
Closes #46