Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 421. Fix account selection #448

Merged
merged 7 commits into from
Aug 8, 2024

Conversation

MytsV
Copy link
Contributor

@MytsV MytsV commented Aug 5, 2024

Fix #421

  • Fix the existing implementation of multiple account selector
  • Fix a test that passed a broken implementation of this selector
  • Handle a 206 response for USERPASS authentication
  • Enhance the visuals of the modal window (centering, overlay)

onClose()
}}
ariaHideApp={false}
overlayClassName="fixed inset-0 z-40 flex items-center justify-center bg-black bg-opacity-50" // will not work if set with twmerge (uses custom regex)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!!

maany added a commit to MytsV/webui that referenced this pull request Aug 8, 2024
@maany maany force-pushed the feature-421-show_select_account_modal branch from ec05297 to cdbba90 Compare August 8, 2024 13:31
@maany maany merged commit 0779bf4 into rucio:master Aug 8, 2024
7 checks passed
MytsV added a commit to MytsV/webui that referenced this pull request Aug 9, 2024
MytsV added a commit to MytsV/webui that referenced this pull request Aug 9, 2024
maany pushed a commit that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login: show a modal to select an account if multiple accounts are found for an indentity
2 participants