Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 10 login page #35

Merged
merged 36 commits into from
Jun 27, 2022
Merged

Feature 10 login page #35

merged 36 commits into from
Jun 27, 2022

Conversation

nimishbongale
Copy link
Contributor

@nimishbongale nimishbongale commented Jun 27, 2022

Adds the draft 1 login page code

Items TBD:

  1. CSS finalization (on-the-fly)
  2. Complete components integration
  3. Removal of global css bit by bit

image

nimishbongale and others added 30 commits June 5, 2022 08:01
…-setup

Feature 2 storybook react ts setup
…ce-third-party-gh-action

Feature 13 custom cicd replace third party gh action
…ce-third-party-gh-action

Rectify git stash
…ce-third-party-gh-action

Add git config to identify user
…ce-third-party-gh-action

Feature 13 custom cicd replace third party gh action
…ce-third-party-gh-action

Feature 13 custom cicd replace third party gh action
…ce-third-party-gh-action

Update GitHub config, force remove folders starting with a "."
@nimishbongale
Copy link
Contributor Author

nimishbongale commented Jun 27, 2022

@maany

Looks like the same issue (commits squash) resurfaced, will have a look into it!

Will make incremental changes as discussed 😄

(Just realized it would be good to have CI/CD for the react app as well! Can/will raise a PR for the same)

@maany
Copy link
Member

maany commented Jun 27, 2022

LGTM, we will open new issues for follow-up enhancements! Great start @nimishbongale

@maany maany merged commit 9bf80e2 into rucio:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants