add middleware to redirect to login #280 #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The limitation with the middleware is that only GET requests can be properly redirected after a successful login Other types of requests cannot be cached in the session as the session object in the middleware is not the same as the one made available to the rest of the application. This is a bug with IronSession.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The limitation with the middleware is that only GET requests can be properly redirected after a successful login Other types of requests cannot be cached in the session because the middleware and the rest of the app use different NextJs runtimes ( edge and node respectively). The session objects in each runtime are independent and cannot share information.
As a result, once a rucio token expires, the user will be redirected to the login page. If the expired token was detected during a GET request, the user will be redirected after login.
In other cases, the user will be redirected to the dashboard.