Feature 270 show error in streamedtable #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 4, 2023 16:12
Added `TableErrorstatus`, added `TableErrorreader` and appropriate fixture * `TableErrorreader` works together with `TableErrorstatus` in the `TableFooter`: an indication of errors is shown in the status "pill" (which sits among the pagination and fetchstatus), but the detailed view can be opened and is shown in `TableErrorreader`. * Added a fixture `mockBaseVM` to mock the base view models (and especially whether they have errors or not: you can pass "none" | "some" | "all" and it will have some or all errors then. Connected Tableerrorstatus and Tableerrorreader via the footer Can close TableErrorreader from within the component
wrote viewmodels to wrap the core entities in `BaseViewmodel`, added fixtures.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data is streamed to the frontend in the form of
ViewModels, these viewmodels can also wrap information on errors that may have occurred. This PR introduces the ability to view these errors from within the UI implemented for theStreamedTable. It also replaces all the core entities with ViewModels, so that the errors can be passed and displayed properly. Replaces the old entity-based fixtures with viewmodel-based ones.