Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Connect List DID to backend #251

Merged

Conversation

ThePhisch
Copy link
Contributor

@ThePhisch ThePhisch commented Jul 18, 2023

Connected backend and frontend on the List DID page. Did some remaining work:

  • removed old Checkbox component, replaced with better one
  • added a function passing the DID search query from the component to the NextJS page
  • used ViewModels instead of the core types
  • Minor reformatting etc.

* DIDMetaView
* ListDID
* ListDIDTable

now use `DIDViewModel` and `DIDMetaViewModel` instead of the types which
were previously imported from core.
@ThePhisch ThePhisch force-pushed the feature-249-connect_list_did_to_backend branch from ddd150b to f3cf918 Compare July 18, 2023 15:13
Anton Schwarz added 4 commits July 18, 2023 17:46
Connected to backend, using a new signature in which we use scope and
name separately instead of the full `did`

Components/Storybook: changed story parameters to match ViewModel
:
Also some Reformatting
The new way of handling it means that there is no more multiselect, but
this matches the rucio way of doing it anyway. Used proper radio
buttons.
ListDID made test work again, Solved build issues
@ThePhisch ThePhisch force-pushed the feature-249-connect_list_did_to_backend branch from 1e8b816 to f8f3ca1 Compare July 18, 2023 15:48
@ThePhisch ThePhisch changed the title Components: Use viewmodels in List DID and associated files Components: Connect List DID to backend Jul 18, 2023
@ThePhisch ThePhisch merged commit 2564fd0 into rucio:master Jul 18, 2023
7 checks passed
@ThePhisch ThePhisch mentioned this pull request Aug 8, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant