Added Modal for Login Multiaccounts select
#237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jul 11, 2023
|
Please rebase to see if the |
ThePhisch
force-pushed
the
feature-235-multi_accounts_modal
branch
from
dc543f3
to
ba0a1a9
Compare
Within the login UI, users can select an account, or have one mapped to them. If multiple accounts can be mapped to the given credentials, the new modal will show up, prompting the user to select an account. To facilitate this, added the optional `rucioMultiAccount?: string` to `AuthViewModel`, this is a comma-separated string of the possible account names. Uses `react-modal` addon. In order to be able to style the modal and the overlay (overlay ~= the container into which the modal is placed, ie the container it is hovering in) using tailwind, the regex to discover tailwind classes was adapted.
ThePhisch
force-pushed
the
feature-235-multi_accounts_modal
branch
from
ba0a1a9
to
67b625e
Compare
maany
reviewed
Jul 12, 2023
will now check whether the modal shows if multiple accounts are set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the login UI, users can select an account, or have one mapped to them. If multiple accounts can be mapped to the given credentials, the new modal will show up, prompting the user to select an account.
To facilitate this, added the optional
rucioMultiAccount?: stringtoAuthViewModel, this is a comma-separated string of the possible account names.Uses
react-modaladdon. In order to be able to style the modal and the overlay (overlay ~= the container into which the modal is placed, ie the container it is hovering in) using tailwind, the regex to discover tailwind classes was adapted.