Feature 187 list did page #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 24 commits
May 5, 2023 15:56
At the moment, it only handles datasets and containers properly. Files
have different metadata.
```
const DIDMetaViewModel = {
name: string
scope: string
account: string
did_type: DIDType
created_at: Date
updated_at: Date
availability: DIDAvailability // Lost/Deleted/Available
obsolete: bool
hidden: bool
suppressed: bool
purge_replicas: bool
is_open: bool
monotonic: false
}
```
but as of now, with no filtering in scopename and no columns for DIDType and Size.
The tables are wonky.
and included in ListDID
…epl inspection pages This concludes the ListDID page for now. Of course, a number of tasks remain: * Dark Mode (especially for the custom tables) * Full Responsiveness (the website has scroll in x-direction even on the large mobile setting) * Handling Files/Datasets/Containers differently (eg files have file replica states/parent DIDs, while datasets have rules/dataset replicas/file replica states)
As per my conversation with Mario, I expect to receive a fixed number of key-value pairs (with known keys) for the didmetadata. There are minor differences between the metadatas for files and colections. I only have one API endpoint (here: `/didmeta`) that returns data of the same format irrespective of the datatype. But keys will have None-values when they should not be set for the given datatype. The further handling will need to be done on the webserver.
Testing this in storybook can be quite tedious, since it is just one component for both collection and file view. Might need to reconsider? (to test, you need to edit the `DIDMeta` object).
as per Martins request on Mattermost
There was an issue with the `search` button, which has `type=submit`, which seems to lead to a page reload. Substituted green submit button with a normal blue one, and the issue is gone. Will need to do some restyling, I think.
Wanted to use a stream and then tanstack, decided against it. Reason is that I only have one row (because we only query metadata for one DID), so streaming rows is not necessary. In addition, this would mean working *against* the framework, which I do not want to do. We expect the backend to provide the `ListDID` component with a single, complete object that can then be parsed by the `DIDMetaView` component. A single boolean parameter can be used to communicate to the components whether the data is ready to be rendered.
Filtering by DID (ie scopename) is possible now. Also added inline DIDTypeTags (their visibility is not yet dependent on whether multiple DID Types were queried).
In DIDListTable
DIDMetaView: for file view, make text of DID Filesize align left ListDID: replace buttons with `Go To DID Page` button which will supply more information.
This includes DIDListTable, DIDMetaView and ListDID components
Smallest supported width is iPhone SE 2, on this screen width, the grid element of the DIDListTable would begin to overflow. In order to prevent this from happening, I set a `min-w-0`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
List DIDPage:DIDListTablethat displays the full DID (scopename)DIDTypeTagsDIDMetaViewcomponent (consisting of non-streaming tables), using the newAvailabilityTagDTOinterface defined inrucio-dto.tsxfor the metadata.The most important unfinished end is how information is piped into the
DIDMetaViewcomponent.