sdk: remove streamElement from presenter error streams #252

src/lib/infrastructure/presenter/list-dids-presenter.ts

@@ -30,7 +30,7 @@ export default class ListDIDsPresenter extends BaseStreamingPresenter<ListDIDsRe
         return viewModel
     }
 
-    streamErrorModelToViewModel(error: ListDIDsError, streamElement: string): ListDIDsViewModel {
+    streamErrorModelToViewModel(error: ListDIDsError): ListDIDsViewModel {
         return {
             status: 'error',
             message: error.message,

src/lib/infrastructure/presenter/list-subscriptions-presenter.ts

@@ -20,7 +20,7 @@ export default class ListSubscriptionsPresenter extends BaseStreamingPresenter<L
         return viewModel;
     }
 
-    streamErrorModelToViewModel(error: ListSubscriptionsError, streamElement: string): SubscriptionViewModel {
+    streamErrorModelToViewModel(error: ListSubscriptionsError): SubscriptionViewModel {
         const viewModel: SubscriptionViewModel = getEmptySubscriptionViewModel();
         viewModel.message = error.message;
         viewModel.status = 'error';

src/lib/sdk/postprocessing-pipeline-elements.ts

@@ -157,24 +157,7 @@ export abstract class BaseStreamingPostProcessingPipelineElement<TRequestModel,
             requestModel: requestModel,
             responseModel: response,
         })
-        // try {
-        //     if (dto.status === 'error') {
-        //         const errorModel: TErrorModel = this.handleGatewayError(dto)
-        //         this.emit('error', errorModel)
-        //         callback()
-        //     }
-        //     const { status, data } = this.validateDTO(dto)
-        //     if(status === 'error') {
-        //         this.emit('error', data)
-        //         callback(data as Error)
-        //     }
-        //     const transformedResponseModel = this.transformResponseModel(responseModel, dto)
-        //     callback(undefined, {
-        //         requestModel: requestModel,
-        //         responseModel: transformedResponseModel
-        //     })
         } catch (error: Error | any) {
-            // this.emit('Unknown error with Gateway Request: ', error)
             const errorModel: TErrorModel = {
                 status: 'error',
                 message: `Unknown Error in pipeline element ${this.constructor.name}`,

src/lib/sdk/presenter.ts

@@ -124,7 +124,7 @@ export abstract class BaseStreamingPresenter<
      * Convert an error that occurred for a given stream element to a view model.
      * @param error An ErrorResponseModel that represents the error that occurred for a given stream element.
      */
-    abstract streamErrorModelToViewModel(error: TErrorModel, streamElement: string): TStreamViewModel
+    abstract streamErrorModelToViewModel(error: TErrorModel): TStreamViewModel
 
     /**
      * Presents a stream of response models.
@@ -156,12 +156,15 @@ export abstract class BaseStreamingPresenter<
                 this.streamResponseModelToViewModel(responseModel)
                 callback(null, JSON.stringify(viewModel))
             } else {
-                const viewModel = this.streamErrorModelToViewModel(responseModel as unknown as TErrorModel, "Presenter")
+                const viewModel = this.streamErrorModelToViewModel(responseModel as unknown as TErrorModel)
                 callback(null, JSON.stringify(viewModel))
             }
         } catch (error) {
             // If an error occurs while processing response or error models, we need to handle it here.
-            callback(error as Error)      
+            callback(null, {
+                status: 'error',
+                message: `The presenter returned with an error while in pipeline element ${this.constructor.name}. Error: ${error}}`,
+            } as TStreamViewModel)      
         }
     }
 

src/lib/sdk/primary-ports.ts

@@ -83,5 +83,5 @@ export interface BaseStreamingOutputPort<TResponseModel extends BaseResponseMode
         responseModel: TResponseModel,
     ): TStreamViewModel
 
-    streamErrorModelToViewModel(error: TErrorModel, streamElement: string): TStreamViewModel
+    streamErrorModelToViewModel(error: TErrorModel): TStreamViewModel
 }

test/sdk/fixtures/presenter.ts

@@ -7,10 +7,10 @@ export class TestPresenter extends BaseStreamingPresenter<
         BaseErrorResponseModel,
         ViewModel
     > {
-        streamErrorModelToViewModel(error: BaseErrorResponseModel, streamElement: string): ViewModel {
+        streamErrorModelToViewModel(error: BaseErrorResponseModel): ViewModel {
             const viewModel: ViewModel = {
                 status: 'error',
-                title: 'failed: ' + error.message + ' for stream element: ' + streamElement,
+                title: 'failed: ' + error.message,
             }
             return viewModel
         }

test/sdk/post-processing-streaming-pipeline/multicall-usecase-pipeline-errors.test.ts

@@ -123,7 +123,17 @@ describe("Post Processing Streaming Pipeline Error Handling", () => {
         })
 
         await done
-        console.log(receivedData)        
+        console.log(receivedData)
+        expect (receivedData).toEqual([
+            {
+                status: 'error',
+                title: 'failed: Failed to authenticate user',
+            },
+            {
+                status: 'error',
+                title: 'failed: Failed to authenticate user'
+            },
+        ])       
 
     })
 })

test/sdk/stream-error-handling.test.ts

@@ -124,6 +124,6 @@ describe("Stream Error Handling", () => {
         await done
         expect(receivedData.length).toBe(3)
         expect(receivedData[2].status).toBe('error')
-        expect(receivedData[2].title).toBe('failed: Failed to process data for stream element: Presenter')
+        expect(receivedData[2].title).toBe('failed: Failed to process data')
     })
 });