Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Event Type page under Operator section #226 #233

Merged
merged 7 commits into from
Sep 13, 2023

Conversation

esilvaju
Copy link
Contributor

No description provided.

@esilvaju esilvaju added the enhancement New feature or request label Jun 26, 2023
@esilvaju esilvaju requested a review from bari12 June 26, 2023 18:35
Copy link
Member

@bari12 bari12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Eraldo, I added some comments.

For the examples I still need to have a look. I am pretty sure we are missing deletion events though :-)

docs/operator/event_type.md Outdated Show resolved Hide resolved
docs/operator/event_type.md Outdated Show resolved Hide resolved
docs/operator/event_type.md Outdated Show resolved Hide resolved
docs/operator/event_type.md Outdated Show resolved Hide resolved
Eraldo Junior added 2 commits June 29, 2023 10:17
Changing all occurrences of Event Type to Notifications and update the section description
@esilvaju

This comment was marked as resolved.

@esilvaju esilvaju self-assigned this Jun 29, 2023
@esilvaju
Copy link
Contributor Author

@bari12, adding the event types related to transfers and deletion that I found on hermes.py.

docs/operator/notifications.md Outdated Show resolved Hide resolved
docs/operator/notifications.md Outdated Show resolved Hide resolved
docs/operator/notifications.md Outdated Show resolved Hide resolved
docs/operator/notifications.md Outdated Show resolved Hide resolved
docs/operator/notifications.md Outdated Show resolved Hide resolved
docs/operator/notifications.md Outdated Show resolved Hide resolved
docs/operator/notifications.md Outdated Show resolved Hide resolved
docs/operator/notifications.md Outdated Show resolved Hide resolved
docs/operator/notifications.md Outdated Show resolved Hide resolved
docs/operator/notifications.md Outdated Show resolved Hide resolved
@esilvaju
Copy link
Contributor Author

@bari12 changes done, I filled up the payloads based on the correspondence of the previous ones.

@bari12 bari12 self-requested a review September 13, 2023 11:41
@bari12 bari12 merged commit 62ee228 into rucio:main Sep 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants