Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix x509 identity to new schema #345

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Fix x509 identity to new schema #345

merged 1 commit into from
Jul 25, 2024

Conversation

mlassnig
Copy link
Contributor

@rdimaio
Copy link
Contributor

rdimaio commented Jul 25, 2024

Not sure why the fwd slash was there in the first place - the changes in this PR match the format in .cfg.template: https://github.com/rucio/rucio/blob/d7c7645b10dd6b904108bd94bd48f6ce14a20d90/etc/rucio.cfg.template#L94

@rdimaio
Copy link
Contributor

rdimaio commented Jul 25, 2024

Something to note:

@mlassnig mlassnig merged commit 1a23877 into master Jul 25, 2024
@mlassnig mlassnig deleted the mlassnig-patch-1 branch July 25, 2024 12:21
@rdimaio
Copy link
Contributor

rdimaio commented Jul 25, 2024

I guess it depends on LegacyDNStringFormat, based on the docstring of this method:

https://github.com/rucio/rucio/blob/d7c7645b10dd6b904108bd94bd48f6ce14a20d90/lib/rucio/core/authentication.py#L45-L74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdimaio rdimaio rdimaio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlassnig @rdimaio