Multi-vo fts cron fixes #226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thysk
reviewed
Feb 8, 2023
There was a problem hiding this comment.
I give these suggestions now, as if secrets can be mounted in a VO specific directory as they are with this cron-job, then that means all files within secrets can have an explicit name , and the secret is created as it currently is {secret}-{vo}, but internally they are all file name wise, identical
| voms-proxy-init2 -valid 24:00 -cert /tmp/{{ voms }}/long.proxy -key /tmp/{{ voms }}/long.proxy -out /tmp/x509up_{{ voms }} -voms {{ voms }} -rfc -timeout 5 | ||
| if [ $RUCIO_FTS_VOMS_{{ vo | upper }} ] | ||
| then | ||
| voms-proxy-init2 -valid 24:00 -cert /tmp/{{ vo }}/long.proxy -key /tmp/{{ vo }}/long.proxy -out /tmp/x509up_{{ vo }} -rfc -timeout 5 -voms $RUCIO_FTS_VOMS_{{ vo | upper }} |
There was a problem hiding this comment.
perhaps the outputs here should also be to the VO directory, and then use a generic name for the output, but organised by the directories, rather than prescribing the naming of the files?
There was a problem hiding this comment.
I agree, it makes it a bit easier to understand and more consistent
| then | ||
| voms-proxy-init2 -valid 24:00 -cert /tmp/{{ vo }}/long.proxy -key /tmp/{{ vo }}/long.proxy -out /tmp/x509up_{{ vo }} -rfc -timeout 5 -voms $RUCIO_FTS_VOMS_{{ vo | upper }} | ||
| else | ||
| voms-proxy-init2 -valid 24:00 -cert /tmp/{{ vo }}/long.proxy -key /tmp/{{ vo }}/long.proxy -out /tmp/x509up_{{ vo }} -rfc -timeout 5 |
|
|
||
| # Delegate the proxy to the requested servers | ||
| {% if RUCIO_FTS_SERVERS is defined %} | ||
| {% set ftses = RUCIO_FTS_SERVERS.split(',') %} | ||
| {% for fts in ftses %} | ||
| fts-rest-delegate --hours=24 --force --key=/tmp/x509up_{{ voms }} --cert=/tmp/x509up_{{ voms }} -s {{ fts }} | ||
| fts-rest-delegate --hours=24 --force --key=/tmp/x509up_{{ vo }} --cert=/tmp/x509up_{{ vo }} -s {{ fts }} |
| {% endfor %} | ||
| {% endif %} | ||
|
|
||
| # Create the corresponding kubernetes secrets if asked | ||
| {% if RUCIO_FTS_SECRETS is defined %} | ||
| {% set secrets = RUCIO_FTS_SECRETS.split(',') %} | ||
| {% for secret in secrets %} | ||
| kubectl create secret generic {{ secret }}-{{ voms }} --from-file=/tmp/x509up_{{ voms }} --dry-run=client -o yaml | kubectl apply --validate=false -f - | ||
| kubectl create secret generic {{ secret }}-{{ vo }} --from-file=/tmp/x509up_{{ vo }} --dry-run=client -o yaml | kubectl apply --validate=false -f - |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made to multi-vo script suggested here rucio/helm-charts#126 :