Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
Bundler::Audit::Database#update!
,#commit_id
and#last_updated_at
fail in multi-threaded environments (like background processing jobs) because they useDir.chdir
.From Ruby docs on
Dir.chdir
:This PR removes the need for
Dir.chdir
by usingOpen3.capture2
from the stdlib with thechdir
option.External behavior should stay the same:
Dir.chdir
raises anErrno::ENOENT
error given an non-existent directory, and the same holds with the new implementation.Fixes #156