Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatible dependency license #535

Closed
jas14 opened this issue Mar 24, 2021 · 1 comment · Fixed by #536
Closed

Incompatible dependency license #535

jas14 opened this issue Mar 24, 2021 · 1 comment · Fixed by #536
Labels
feature

Comments

@jas14
Copy link
Contributor

jas14 commented Mar 24, 2021

Summary

Dependency mimemagic was previously licensed under the MIT License, but had to change to GPL this morning. All versions under MIT have been yanked, and GPL is incompatible with Jets MIT license. See mimemagicrb/mimemagic#97.

Recommendations

I suggest that the mimemagic dependency be replaced with mini_mime.

mimemagic appears to be used only in lib/jets/internal/app/controllers/jets/public_controller.rb, which calls MimeMagic.by_path (which infers a file's MIME type from its extension). mini_mime does similar inference, but it is licensed under the MIT License.
@jas14 jas14 added the feature label Mar 24, 2021
tongueroo added a commit that referenced this issue Mar 24, 2021
@tongueroo
use mini_mime instead
ae7b45b 
closes #535
@tongueroo tongueroo mentioned this issue Mar 24, 2021
Merged
3 tasks
@tongueroo
Copy link
Collaborator

Released in v3.0.3

AlexGascon added a commit to AlexGascon/alexgascon-api that referenced this issue Mar 27, 2021
@AlexGascon
Updating Jets to fix mimemagic issue
b49f526 
The `mimemagic` has changed license, and previous versions under a different license have been removed from available repositories like Rubygems. This is causing CircleCI builds to fail.

```
Your bundle is locked to mimemagic (0.3.5), but that version could not be found
in any of the sources listed in your Gemfile. If you haven't changed sources,
that means the author of mimemagic (0.3.5) has removed it. You'll need to update
your bundle to a version other than mimemagic (0.3.5) that hasn't been removed
in order to install
```

From https://app.circleci.com/pipelines/github/AlexGascon/alexgascon-api/23/workflows/248ed96c-908d-469e-9697-c3c6af333ff9/jobs/61

Jets has removed the dependency in the 3.0.3 release. See rubyonjets/jets#535

This commit updates Jets to unblock builds
@AlexGascon AlexGascon mentioned this issue Mar 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use mini_mime instead rubyonjets/jets
2 participants
@tongueroo @jas14