Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add methods to get current app env #191

Merged
merged 2 commits into from
Feb 4, 2013
Merged

Add methods to get current app env #191

merged 2 commits into from
Feb 4, 2013

Conversation

jjaffeux
Copy link
Contributor

@jjaffeux jjaffeux commented Feb 4, 2013

No description provided.

@supermarin
Copy link
Contributor

Looks good, although I'd prefer if you called the method environment, and since it returns a string (not bool), name without a question mark.

@jjaffeux
Copy link
Contributor Author

jjaffeux commented Feb 4, 2013

Yep very valid points, updated.

supermarin pushed a commit that referenced this pull request Feb 4, 2013
Merge pull request #191 from jjaffeux/app-env
8e33d55 
Add methods to get current app env
@supermarin supermarin merged commit 8e33d55 into rubymotion-community:master Feb 4, 2013
@supermarin
Copy link
Contributor

👍 thanks

@clayallsopp clayallsopp mentioned this pull request Apr 11, 2013
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jjaffeux @supermarin