Fix segfault, disable V8's thread-isolated allocator

[bnoordhuis]

Fixes: #300

[bnoordhuis]

This is against V8 12.x. Is there a specific branch I should be targeting instead of main? libv8-node-22?

[SamSaffron]

Sorry for the short reply, getting late :) You will need to also edit version.rb to target the right version, we reverted that when we were debugging the segfaults Is this patch going to be easy to maintain?

…

On Tue, 20 Aug 2024 at 7:53 PM, Ben Noordhuis ***@***.***> wrote: This is against V8 12.x. Is there a specific branch I should be targeting instead of main? libv8-node-22? — Reply to this email directly, view it on GitHub <#311 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAABIXON4BC727IOZWFNCXDZSMGYLAVCNFSM6AAAAABMZQFYZ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJYGQ2TCOJSGQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[bnoordhuis]

You will need to also edit version.rb to target the right version

Ah, that makes perfect sense! Updated.

Is this patch going to be easy to maintain?

It should be because it should be temporary. I'll back-port the V8 fix to Node's V8 fork.

[bnoordhuis]

I'll take a closer look tomorrow why rake test segfaults (it's not a pkey thing) but if it's not something straightforward, I'll just PR libv8-node instead and disable PKRU in V8.

[bnoordhuis]

I'll PR libv8-node instead, closing.

edit: rubyjs/libv8-node#53