Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Improve Documentation on Rubocop #384

Merged
merged 1 commit into from
Oct 20, 2018
Merged

Conversation

alex-tan
Copy link
Contributor

  • Outline directions to enable rubocop formatting in two steps
  • Group all settings changes into one example config
  • Add config setting "editor.formatOnSave": true

The existing README instructions didn't work for me without setting "editor.formatOnSave" to true. I also updated the README to reflect that the formatOnSaveTimeout setting is now in VSCode.

  • [] The build passes
  • [] TSLint is mostly happy
  • [] Prettier has been run

@daniloisr
Copy link

This looks good, can you rebase with the latest master? cc/ @wingrunr21

- Outline directions in steps
- Group all settings changes into one example config
- Add config setting `"editor.formatOnSave": true`
@alex-tan
Copy link
Contributor Author

@daniloisr yep, rebased!

@wingrunr21
Copy link
Collaborator

Thanks! I'll go ahead and merge this as-is but FYI installing rubocop globally won't be required in the future!

@wingrunr21 wingrunr21 merged commit 6b33774 into rubyide:master Oct 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants