Added support for ruby.format, defaults to false (no formatting). #298
Conversation
it to 'rubocop' to enable rubocop formatting.
src/format/RuboCop.ts
Outdated
|
|
||
| import * as cp from "child_process"; |
There was a problem hiding this comment.
Whitespace changes here. VSCode's guidelines use tabs
There was a problem hiding this comment.
I'd be happy to dig up a prettier config that matches the VSCode guidelines and start using it for vscode-ruby... Might result in a lot of changes, though. Especially if we decided to just run it in one PR. Separate PR, perhaps?
There was a problem hiding this comment.
Converting the whole codebase should be a standalone PR. In the mean time...hand format? Sorry but following the VSCode guidelines is in the PR template
There was a problem hiding this comment.
See the new commit in #297. If that one looks good, let me know and I'll make the same change here.
I re-ran prettier with the following options. We should start using this ASAP and then we could avoid these discussions forever. :)
{
"printWidth": 100,
"singleQuote": true,
"trailingComma": "es5",
"useTabs": true
}
There was a problem hiding this comment.
Good to know on the prettier options. We can add that at a later time. In the mean time, people will have to continue to suffer through the code style guidelines by hand.
Added support for ruby.format, defaults to false (no formatting). Set it to 'rubocop' to enable rubocop formatting. Fixes #295.