-
Notifications
You must be signed in to change notification settings - Fork 286
Conversation
I also made the changes for I also edited the if string =~ /\d{4}/
#not indent properly
end Generally speaking, the semicolon there could also impose the same problem. EDIT: Okay, I found a more elegant approach to this. It now takes everything between quotes or |
ping @rebornix |
Hi @TeeSeal Would you be willing to reopen this PR against my fork? Fork: https://github.com/wingrunr21/vscode-ruby-lang See #239 (comment) for more information Thanks! |
@wingrunr21 okay, will do! |
@TeeSeal your PR LGTM, thanks for your contribution. |
Ye I thought this place is dead so I didn’t bother updating this source branch |
There are still some issues they are a bit harder to handle, Ill investigate those, see if I can do anything about them and open another PR |
@TeeSeal thanks, look forward to it ;) |
Refer the following pull request and the issues linked in it:
microsoft/vscode#40049
@rebornix
This PR seems to come into a bit of conflict with #223, should make a decision on which one we're going to use.
Here's the thing:
case
doesn't indent the next line andwhen
doesn't unindent, the indentation will be ok only while we're addingwhen
clauses, but will break when we useelse
and/orend
(because these 2 do unindent). The result of using the changes made in Fix Travis #233 would be this:case
statement does indent the next line but any ofwhen
,else
andend
will unindent leading to a desired output: