Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

adjust erb comment configuration #224

Merged
merged 2 commits into from
Jan 24, 2018

Conversation

NickWarm
Copy link
Contributor

Some times I need to program more ruby code in erb, i.e:

<%
  set_meta_tags title: "title",
                og: {
                    title: "my title",
                    description: "some description"
                },
                image: "image path"
%>

vscode-ruby default comment will create <%# %>, may look like

<%
  set_meta_tags title: "title",
                og: {
                    title: "my title",
                    description: "some description"
                },
                <%# image: "image path" %>
%>

but the ideal comment should be

<%
  set_meta_tags title: "title",
                og: {
                    title: "my title",
                    description: "some description"
                },
                # image: "image path"
%

so I adjust the comment configuration

@rebornix rebornix merged commit aca5f32 into rubyide:master Jan 24, 2018
@rebornix
Copy link
Member

@NickWarm it's neat, thanks!

wingrunr21 added a commit that referenced this pull request Feb 4, 2018
This allows the fix attempted in #224 to still work while also
supporting proper ERB comments
wingrunr21 added a commit that referenced this pull request Feb 4, 2018
This allows the fix attempted in #224 to still work while also
supporting proper ERB comments
@wingrunr21 wingrunr21 mentioned this pull request Feb 4, 2018
2 tasks
@MaxencePautre
Copy link

Hi ! Thanks for this upgrade but how do you apply it in VScode ? I still get the previous behavior :/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants