Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Highlighting for '!!' (double bang) #573

Closed
AlexStoll opened this issue Dec 22, 2019 · 2 comments
Closed

Highlighting for '!!' (double bang) #573

AlexStoll opened this issue Dec 22, 2019 · 2 comments

Comments

@AlexStoll
Copy link

AlexStoll commented Dec 22, 2019

Your environment

  • vscode-ruby version: 0.26.0
  • Ruby version: N/A
  • Ruby version manager (if any): N/A
  • VS Code version: 1.41.0
  • Operating System: mac 10.14.5
  • Using language server? (eg useLanguageServer is true?)

Expected behavior

Syntax highlighting for 'double bang' (!!some_thing) seems off.
I would expect it to look like it does in Sublime Text - show below.
Sublime screenshot.

Actual behavior

Instead, it does the first ! in red, but assumes the second one is part of whatever comes after. This doesn't seem like the clearest highlighting. Here's an example of how it looks for me.
Example in VS Code

@wingrunr21
Copy link
Collaborator

I'll try and find some time to take a look. In the mean time, the grammar has tests and is available here. A PR would be great.

@AlexStoll
Copy link
Author

AlexStoll commented Dec 23, 2019 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants