Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintainer Role #4883

Merged
merged 30 commits into from
Oct 14, 2024
Merged

Maintainer Role #4883

merged 30 commits into from
Oct 14, 2024

Commits on Oct 9, 2024

  1. Add Access Level field to Ownership table and update RubyGem policies… 

    … to check for the level of access
    @colby-swandale
    colby-swandale committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    971521f View commit details
    Browse the repository at this point in the history

  2. Add Ownership edit form to owners table

    @colby-swandale
    colby-swandale committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    a8185f4 View commit details
    Browse the repository at this point in the history

  3. Add role field to add Ownership form

    @colby-swandale
    colby-swandale committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    4e2128c View commit details
    Browse the repository at this point in the history

  4. Replace Access Level field with Role

    @colby-swandale
    colby-swandale committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    8765cc4 View commit details
    Browse the repository at this point in the history

  5. better validate the role in Owners API endpoint

    @colby-swandale
    colby-swandale committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    89d0b83 View commit details
    Browse the repository at this point in the history

  6. Refactor Access Level field to be Role instead

    @colby-swandale
    colby-swandale committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    b19c985 View commit details
    Browse the repository at this point in the history

  7. Notify users when their Role was updated

    @colby-swandale
    colby-swandale committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    1fbde71 View commit details
    Browse the repository at this point in the history

  8. Don’t allow a user to update their own Ownership

    @colby-swandale
    colby-swandale committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    a8758c1 View commit details
    Browse the repository at this point in the history

  9. prevent maintainers for accessing trusted publishing

    @colby-swandale
    colby-swandale committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    c4055fd View commit details
    Browse the repository at this point in the history

  10. Replace Role type object with an Enum

    @colby-swandale
    colby-swandale committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    af363a5 View commit details
    Browse the repository at this point in the history

  11. separate checking for onwnership and permissions into separate methods

    @colby-swandale
    colby-swandale committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    6651360 View commit details
    Browse the repository at this point in the history

  12. Add Minimum Role Scope to the Ownership model 

    Replace the raw sql with something nicer
    @colby-swandale
    colby-swandale committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    9e82ab2 View commit details
    Browse the repository at this point in the history

  13. Add translations for Role field

    @colby-swandale
    colby-swandale committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    eac05b7 View commit details
    Browse the repository at this point in the history

  14. Record event when a ownership role is updated

    @colby-swandale
    colby-swandale committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    40ac001 View commit details
    Browse the repository at this point in the history

  15. Indicate what role the user was updated to in the notification email

    @colby-swandale
    colby-swandale committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    02b0b71 View commit details
    Browse the repository at this point in the history

  16. Fix the wrong select values being passed to the edit/create ownership… 

    … form
    @colby-swandale
    colby-swandale committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    05908c8 View commit details
    Browse the repository at this point in the history

  17. Always email owners of any changes to their roles

    @colby-swandale
    colby-swandale committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    5025a66 View commit details
    Browse the repository at this point in the history

  18. Fixup breaking test

    @colby-swandale
    colby-swandale committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    0c75298 View commit details
    Browse the repository at this point in the history

  19. Remove tests that are no longer relevant

    @colby-swandale
    colby-swandale committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    70db69b View commit details
    Browse the repository at this point in the history

  20. Fixup migration file name

    @colby-swandale
    colby-swandale committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    104b857 View commit details
    Browse the repository at this point in the history

  21. add role to Membership

    @colby-swandale
    colby-swandale committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    4ce3489 View commit details
    Browse the repository at this point in the history

  22. Refactor Ownership policies to cover updating user's own ownership 

    Make authorization failures more helpful on ownership changes.
We were sometimes returning just the text 'Forbidden' when
really we need to say that you can't edit your own role or
explain the authorization problem, if possible, then redirect
back to the rubygem page.
    @martinemde @colby-swandale
    martinemde authored and colby-swandale committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    488c70c View commit details
    Browse the repository at this point in the history

  23. Improve readability of role access list

    @martinemde @colby-swandale
    martinemde authored and colby-swandale committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    8ba06a2 View commit details
    Browse the repository at this point in the history

  24. Add organization policy object

    @colby-swandale
    colby-swandale committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    645ea76 View commit details
    Browse the repository at this point in the history

  25. record the previous value when recording the change role event

    @colby-swandale
    colby-swandale committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    ed1be33 View commit details
    Browse the repository at this point in the history

  26. Move method to OrganizationPolicy

    @martinemde @colby-swandale
    martinemde authored and colby-swandale committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    6b0af0a View commit details
    Browse the repository at this point in the history

  27. Fix new lint error

    @martinemde @colby-swandale
    martinemde authored and colby-swandale committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    863c195 View commit details
    Browse the repository at this point in the history

  28. Update app/models/events/rubygem_event.rb 

    Co-authored-by: Martin Emde <martinemde@users.noreply.github.com>
    @colby-swandale @martinemde
    colby-swandale and martinemde committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    2336b88 View commit details
    Browse the repository at this point in the history

  29. Fix breaking test

    @colby-swandale
    colby-swandale committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    a8d7713 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Remove unused code

    @colby-swandale
    colby-swandale committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    fc63946 View commit details
    Browse the repository at this point in the history