Add path arugment to rake task for updating versions list file #1402
Conversation
|
|
Don't we only update this in the other repository? |
Idea is to generate We have more sensible plan/requirements logged at #1400 |
|
@dwradcliffe we currently keep the file in the other repo, but we are generating it from the rubygems production database as a precursor to getting rid of the other repo completely. once everything is being served from this app, we'll move the versions file to S3 or something and retire the other repo. |
| file_path = Rails.application.config.rubygems['versions_file_location'] | ||
| versions_file = CompactIndex::VersionsFile.new file_path | ||
| task :update_versions_file, [:file_path] => :environment do |_t, args| | ||
| raise "#{args[:file_path]} does not exist" unless File.exist?(args[:file_path]) |
There was a problem hiding this comment.
I think we should not raise since this will often be a completely new file on disk... for this task, the file is written from scratch, not updating from an old file.
There was a problem hiding this comment.
Should I update it to creation of the file if one doesn't exist?
|
@indirect Ah ok. Currently we're automatically syncing the other repo on all the app servers and symlinking the file (via Chef). So it will be simpler to update the file in the other repo until we're totally done with it. |
|
☔ The latest upstream changes (presumably #1453) made this pull request unmergeable. Please resolve the merge conflicts. |
usage: rake compact_index:update_versions_file["path_to_file/versions.list"]
|
☔ The latest upstream changes (presumably #1459) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@sonalkr132 Are you still working on this? If not, would it be an idea to close this PR? That way the list open PRs is kept to active ones only :-) |
Not really. This is an insufficient solution anyway. |
usage:
rake compact_index:update_versions_file["path_to_file/versions.list"]