fix: Define 'sync' method on logger for compatibility with Puma > 5 #355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Since at least puma/puma@a284179, puma has required that the logger respond to a
sync
method.This implements the above method. With this change, Gemstash will start with Puma 6.3.1 when the
--no-daemonize
flag is passed.It might also be worth changing the
daemonize
default tofalse
- Puma versions greater than ~5.0 do not support demonizing (without https://github.com/kigster/puma-daemon or alternative)?Tasks:
I will abide by the code of conduct.