Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UpstreamSource intermediate specs from upstream #337

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Make UpstreamSource intermediate specs from upstream #337

merged 1 commit into from
Jun 16, 2023

Conversation

tedgarb
Copy link
Contributor

@tedgarb tedgarb commented Jun 15, 2023

As discovered in #336, the retirement of the v1 dependencies API revealed that UpstreamSource, when the dependencies API is unavailable, tells the client to go talk to rubygems directly for the spec files. This model does not work in general, because there is no guarantee that the client can access rubygems directly. This commit changes UpstreamSource to intermediate the connection

Description:


Tasks:

  • Describe the problem / feature
  • Write tests

I will abide by the code of conduct.

As discovered in #336, the retirement of the v1 dependencies API revealed that UpstreamSource, when the dependencies API is unavailable, tells the client to go talk to rubygems directly for the spec files. This model does not work in general, because there is no guarantee that the client can access rubygems directly. This commit changes UpstreamSource to intermediate the connection
@indirect
Copy link
Member

Have you tested this? I don't think it will allow installation of gems because the /quick/Marshal.4.8/ specs aren't also proxied.

@tedgarb
Copy link
Contributor Author

tedgarb commented Jun 16, 2023

quick/Marshal is handled in that class via the cache mechanism in

This patch is identical to the code I am running in production in my environment today, which is letting me install gems and to search for them

@indirect
Copy link
Member

Ah, got it. Thanks for explaining!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants