Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various rubocop/codeclimate issues #238

Closed
wants to merge 7 commits into from

Conversation

tchia04
Copy link
Contributor

@tchia04 tchia04 commented Jun 1, 2019

This should fix the following issue at https://codeclimate.com/github/bundler/gemstash/builds/115

/usr/local/lib/ruby/site_ruby/2.4.0/rubygems/core_ext/kernel_require.rb:122:in `require': cannot load such file -- rubocop-performance (LoadError)
	from /usr/local/lib/ruby/site_ruby/2.4.0/rubygems/core_ext/kernel_require.rb:122:in `require'
	from /usr/local/bundle/gems/rubocop-0.52.1/lib/rubocop/config_loader_resolver.rb:15:in `block in resolve_requires'

@tchia04
Copy link
Contributor Author

tchia04 commented Jun 1, 2019

I don't know why the codeclimate is not working here. Maybe it's disabled?
It works fine in my fork at tchia04#2

@bronzdoc
Copy link
Member

bronzdoc commented Jun 1, 2019

Hey @tchia04 We don't use codeclimate in this repo, so i don't really understand what is this fixing.

Seems like we do @olleolleolle? i have never seen that bot in any PR submited

Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this repair!

Could you make it a single commit?

.codeclimate.yml Outdated
- "**.rb"
exclude_paths:
- spec/
# Avaiable channels: https://docs.codeclimate.com/docs/rubocop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny typo, should be "available"

@tchia04
Copy link
Contributor Author

tchia04 commented Jun 3, 2019

I am not sure how to squash all the commit into one. I counted the number of commits from HEAD and pass it to git rebase -i HEAD~X and it turns out to either pick up too many commits or too less commits. I believe there is an option to squash the commit on the merge button. Could you try that

@bronzdoc
Copy link
Member

closed in favor of #241

@bronzdoc bronzdoc closed this Jun 19, 2019
ghost pushed a commit that referenced this pull request Jun 19, 2019
241: Fix various rubocop/codeclimate issues r=bronzdoc a=bronzdoc

#238 Squashed :shipit: 

Co-authored-by: Tony Chia <tchia04@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants