-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various rubocop/codeclimate issues #238
Conversation
…into fix_codeclimate * 'fix_codeclimate' of https://github.com/tchia04/gemstash: Fix various rubocop/codeclimate issues
…into fix_codeclimate * 'fix_codeclimate' of https://github.com/tchia04/gemstash: Fix various rubocop/codeclimate issues
I don't know why the codeclimate is not working here. Maybe it's disabled? |
Seems like we do @olleolleolle? i have never seen that bot in any PR submited |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this repair!
Could you make it a single commit?
.codeclimate.yml
Outdated
- "**.rb" | ||
exclude_paths: | ||
- spec/ | ||
# Avaiable channels: https://docs.codeclimate.com/docs/rubocop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny typo, should be "available"
I am not sure how to squash all the commit into one. I counted the number of commits from HEAD and pass it to git rebase -i HEAD~X and it turns out to either pick up too many commits or too less commits. I believe there is an option to squash the commit on the merge button. Could you try that |
closed in favor of #241 |
This should fix the following issue at https://codeclimate.com/github/bundler/gemstash/builds/115