Avoid Rubocop warnings #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bronzdoc
approved these changes
Dec 10, 2018
|
@bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Dec 10, 2018
210: Avoid Rubocop warnings r=bronzdoc a=olleolleolle This PR avoids the warnings output from Rubocop ``` ..................................spec/support/simple_server.rb: Style/MethodName has the wrong namespace - should be Naming ..spec/support/slow_simple_server.rb: Style/MethodName has the wrong namespace - should be Naming .................................................................``` Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>
Build succeeded |
ghost
merged commit
olleolleolle
pushed a commit
to olleolleolle/gemstash
that referenced
this pull request
Dec 10, 2018
199: Update rack-test requirement from ~> 0.6 to ~> 1.1 r=bronzdoc a=dependabot[bot] Updates the requirements on [rack-test](https://github.com/rack-test/rack-test) to permit the latest version. <details> <summary>Release notes</summary> *Sourced from [rack-test's releases](https://github.com/rack-test/rack-test/releases).* > ## v1.1.0 > ## 1.1.0 / 2018-07-21 > > * Breaking changes: > * None > > * Minor enhancements / new functionality: > * [GitHub] Added configuration for Stale (Per Lundberg [rubygems#232](https://github-redirect.dependabot.com/rack-test/rack-test/issues/232)) > * `follow_direct`: Include `rack.session.options` (Mark Edmondson [rubygems#233](https://github-redirect.dependabot.com/rack-test/rack-test/issues/233)) > * [CI] Add simplecov (fatkodima [rubygems#227](https://github-redirect.dependabot.com/rack-test/rack-test/issues/227)) > > Bug fixes: > * Follow relative locations correctly. (Samuel Williams [rubygems#230](https://github-redirect.dependabot.com/rack-test/rack-test/issues/230)) </details> <details> <summary>Changelog</summary> *Sourced from [rack-test's changelog](https://github.com/rack-test/rack-test/blob/master/History.md).* > ## 1.1.0 / 2018-07-21 > > * Breaking changes: > * None > > * Minor enhancements / new functionality: > * [GitHub] Added configuration for Stale (Per Lundberg [rubygems#232](https://github-redirect.dependabot.com/rack-test/rack-test/issues/232)) > * follow_direct: Include rack.session.options (Mark Edmondson [rubygems#233](https://github-redirect.dependabot.com/rack-test/rack-test/issues/233)) > * [CI] Add simplecov (fatkodima [rubygems#227](https://github-redirect.dependabot.com/rack-test/rack-test/issues/227)) > > Bug fixes: > * Follow relative locations correctly. (Samuel Williams [rubygems#230](https://github-redirect.dependabot.com/rack-test/rack-test/issues/230)) > > ## 1.0.0 / 2018-03-27 > > * Breaking changes: > * Always set CONTENT_TYPE for non-GET requests > (Per Lundberg [rubygems#223](https://github-redirect.dependabot.com/rack-test/rack-test/issues/223)) > > * Minor enhancements / bug fixes: > * Create tempfile using the basename without extension > (Edouard Chin [rubygems#201](https://github-redirect.dependabot.com/rack-test/rack-test/issues/201)) > * Save `session` during `follow_redirect!` > (Alexander Popov [rubygems#218](https://github-redirect.dependabot.com/rack-test/rack-test/issues/218)) > * Document how to use URL params with DELETE method > (Timur Platonov [rubygems#220](https://github-redirect.dependabot.com/rack-test/rack-test/issues/220)) > > ## 0.8.3 / 2018-02-27 > > * Bug fixes: > * Do not set Content-Type if params are explicitly set to nil > (Bartek Bułat [rubygems#212](https://github-redirect.dependabot.com/rack-test/rack-test/issues/212)). Fixes [rubygems#200](https://github-redirect.dependabot.com/rack-test/rack-test/issues/200). > * Fix `UploadedFile#new` regression > (Per Lundberg [rubygems#215](https://github-redirect.dependabot.com/rack-test/rack-test/issues/215)) > > * Minor enhancements > * [CI] Test against Ruby 2.5 (Nicolas Leger [rubygems#217](https://github-redirect.dependabot.com/rack-test/rack-test/issues/217)) > > ## 0.8.2 / 2017-11-21 > > * Bug fixes: > * Bugfix for `UploadedFile.new` unintended API breakage. > (Per Lundberg [rubygems#210](https://github-redirect.dependabot.com/rack-test/rack-test/issues/210)) > > ## 0.8.0 / 2017-11-20 > > * Known Issue > * In `UploadedFile.new`, when passing e.g. a `Pathname` object, > errors can be raised (eg. `ArgumentError: Missing original_filename > for IO`, or `NoMethodError: undefined method 'size'`) See [rubygems#207](https://github-redirect.dependabot.com/rack-test/rack-test/issues/207), [rubygems#209](https://github-redirect.dependabot.com/rack-test/rack-test/issues/209). ></table> ... (truncated) </details> <details> <summary>Commits</summary> - See full diff in [compare view](https://github.com/rack-test/rack-test/commits/v1.1.0) </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. --- **Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit. You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com). <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details> Co-authored-by: dependabot[bot] <support@dependabot.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids the warnings output from Rubocop